Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLClipping: Set numIntersection to 0 in projectPlanes(). #18691

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

ricardoreiter
Copy link

@ricardoreiter ricardoreiter commented Feb 20, 2020

Fixed #18675.

When setState() gets called with a material that has no clipping planes and shadows are enabled, it will enter this line

projectPlanes( null );

Which resets the numPlanes but not the numIntersection which was dirty with old values from previous materials with clipping planes.

@Mugen87 Mugen87 changed the title WebGLClipping - set numIntersection to 0 in projectPlanes() WebGLClipping: Set numIntersection to 0 in projectPlanes(). Feb 20, 2020
@mrdoob mrdoob added this to the r114 milestone Feb 20, 2020
@mrdoob mrdoob merged commit f764d28 into mrdoob:dev Feb 20, 2020
@mrdoob
Copy link
Owner

mrdoob commented Feb 20, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance issue with intersection clippingPlanes
3 participants