Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSM: Remove redundant "toRad" function #18704

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

gkjohnson
Copy link
Collaborator

Removes the toRad functions and replaces it with MathUtils.degToRad.

I'm looking into making some other changes to the CSM example coming up including:

  • Using named imports to be consistent with the other examples.
  • Adding support for orthographic cameras for convenience
  • Adding fade between cascades

@vhawk Let me know what you think!

@StrandedKitty
Copy link
Contributor

It will be great if you improve my example. At some point I tried to implement smooth interpolation between cascades, but I haven't published it because it made shader code even more ugly.

@mrdoob mrdoob added this to the r114 milestone Feb 22, 2020
@mrdoob mrdoob merged commit 5fb5487 into mrdoob:dev Feb 22, 2020
@mrdoob
Copy link
Owner

mrdoob commented Feb 22, 2020

Thanks!

@gkjohnson gkjohnson deleted the shadow-cascade-remove-torad branch February 22, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants