Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression Testing: Updating 3 screenshots. #18708

Merged
merged 2 commits into from
Feb 23, 2020
Merged

Regression Testing: Updating 3 screenshots. #18708

merged 2 commits into from
Feb 23, 2020

Conversation

munrocket
Copy link
Contributor

No description provided.

@munrocket
Copy link
Contributor Author

munrocket commented Feb 23, 2020

I am updated 3 screenshot and all looks ok... but actually I am updated one screenshot with a bug in GLTF loader in dev branch.

Look here please:
expected: https://threejs.org/examples/?q=ligh#webgl_lightshafts
actual:https://rawcdn.githack.com/munrocket/three.js/e63612ca1090354a42a87a9b040fa8696b5e803d/examples/webgl_lightshafts.html

Can you notice that FrontSide changed to BackSide? When you will fix this bug, just update screenshot again with

npm run make-screenshot webgl_lightshafts

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 23, 2020

Can you please add after this line:

child.material.alphaTest = 0.5;

this code

child.material.depthWrite = true;

That should fix the example for now. It seems the asset has problems in general and maybe need to be changed/replaced in the future.

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 23, 2020

Merging this for now so the Travis builds no longer fail

@Mugen87 Mugen87 changed the title Updating 3 screenshots Regression Testing: Updating 3 screenshots. Feb 23, 2020
@Mugen87 Mugen87 merged commit 83487e5 into mrdoob:dev Feb 23, 2020
Repository owner deleted a comment from munrocket Feb 23, 2020
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 23, 2020

@munrocket Sorry, I've accidentally deleted your comment. Not sure why, but I had some issues with the github GUI on my smartphone today.

@munrocket
Copy link
Contributor Author

np!

@mrdoob
Copy link
Owner

mrdoob commented Feb 24, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants