Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: ignore css3d_youtube. #18732

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Tests: ignore css3d_youtube. #18732

merged 1 commit into from
Feb 26, 2020

Conversation

munrocket
Copy link
Contributor

@munrocket munrocket commented Feb 25, 2020 •
edited by Mugen87
Loading

  • css3d_youtube in exception list

@munrocket munrocket mentioned this pull request Feb 25, 2020
Closed
@mrdoob mrdoob added this to the r114 milestone Feb 25, 2020
@mrdoob
Copy link
Owner

mrdoob commented Feb 25, 2020 •
edited
Loading

Do we need two folders? screenshots and thumbnails?

Could we instead do css2d_label_thumbnail.png?

@mrdoob
Copy link
Owner

mrdoob commented Feb 25, 2020

I think you have included too many changes in a single PR.
The thumbnails change may block all the other changes.

@munrocket munrocket changed the title Tests: simplify script with beginFrame API Tests: ignore css3d_youtube and generate thumbnails Feb 26, 2020
@munrocket
Copy link
Contributor Author

Yes you right, better not to touch it without big reason because it's fragile. I am just fix css3d_youtube and generated some thumbnails.

@Mugen87 Mugen87 changed the title Tests: ignore css3d_youtube and generate thumbnails Tests: ignore css3d_youtube. Feb 26, 2020
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 26, 2020

I am just fix css3d_youtube and generated some thumbnails.

Are you sure this is correct? The PR still contains many changes...

@munrocket munrocket mentioned this pull request Feb 26, 2020
Merged
@munrocket
Copy link
Contributor Author

Ok, I am splited to 3 PRs.
Nvm.

@mrdoob mrdoob merged commit 81bd68d into mrdoob:dev Feb 26, 2020
@mrdoob
Copy link
Owner

mrdoob commented Feb 26, 2020

Thanks!

@munrocket munrocket mentioned this pull request Feb 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r114
Development

Successfully merging this pull request may close these issues.
3 participants
@munrocket @mrdoob @Mugen87