CSM: Remove array allocation in getBreaks, getExtendedBreaks #18735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #18724.
Modifies the
getBreaks
function andgetExtendedBreaks
function to reuse existing arrays rather than creating new ones every call to prevent garbage collection.This also implies a small API change to
customSplitsCallback
, which now needs to modify an existing array intarget
rather than return a new one:Temporary Live Link:
https://raw.githack.com/gkjohnson/three.js/csm-breaks-cache-arrays/examples/webgl_shadowmap_csm.html
@vhawk
Edit: Looks like the CI failure is from
css3d_youtube
diff again