Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: set .depthWrite to false for transparent materials #18754

Merged
merged 2 commits into from
Feb 27, 2020
Merged

Examples: set .depthWrite to false for transparent materials #18754

merged 2 commits into from
Feb 27, 2020

Conversation

WestLangley
Copy link
Collaborator

Use the coding pattern we are currently recommending for this use case.

@WestLangley WestLangley added this to the r114 milestone Feb 27, 2020
@mrdoob
Copy link
Owner

mrdoob commented Feb 27, 2020

set to 1 when transparency is non-zero

What does that mean? 🤔

@WestLangley
Copy link
Collaborator Author

@mrdoob See #18695 (comment).

@mrdoob
Copy link
Owner

mrdoob commented Feb 27, 2020

Ah! I understand now.

How about // set to 1 when material.transparency is non-zero?
Or // use material.transparency for glass materials?

@WestLangley
Copy link
Collaborator Author

@mrdoob I implemented both suggestions! :-)

@mrdoob
Copy link
Owner

mrdoob commented Feb 27, 2020

Pretty clear now!

@mrdoob mrdoob merged commit a8787af into mrdoob:dev Feb 27, 2020
@mrdoob
Copy link
Owner

mrdoob commented Feb 27, 2020

Thanks!

@WestLangley WestLangley deleted the dev_transparency branch February 27, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r114
Development

Successfully merging this pull request may close these issues.
2 participants
@WestLangley @mrdoob