WebGLTextures: WebGL2 framebuffer RGBformat fallback #18859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sciecode
commented
Mar 10, 2020
sciecode
force-pushed
the
dev-webgl2-framebuffer
branch
from
79e4d52 to
98114a1
Compare
Mugen87
approved these changes
Mar 10, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18858
Aside from the case explicited by the issue, there was also the need for fallback when using
RenderBufferStorage( multisampled rendertarget ).Thoroughly tested the behavior in both WebGL1 and WebGL2, everything should be working correctly.
requires build update