Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLShadowMap: Simplify morph targets check. #18989

Merged
merged 3 commits into from
Apr 6, 2020
Merged

WebGLShadowMap: Simplify morph targets check. #18989

merged 3 commits into from
Apr 6, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 28, 2020

The updateMorphTargets() methods of Mesh and Points only support BufferGeometry since a while now. Hence, I think it's okay to remove some legacy code in WebGLShadowMap.

@Mugen87 Mugen87 added this to the r116 milestone Mar 31, 2020
@mrdoob
Copy link
Owner

mrdoob commented Apr 3, 2020 •
edited
Loading

Just double checking...
This removes support for Geometry with morph targets in WebGLShadowMap, right?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 3, 2020

Exactly.

@mrdoob
Copy link
Owner

mrdoob commented Apr 6, 2020

Hmm... Oh! Is it because there is no way a Geometry can reach here because by this point we have already converted it to BufferGeometry?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 6, 2020 •
edited
Loading

Is it because there is no way a Geometry can reach here because by this point we have already converted it to BufferGeometry?

Up to now, WebGLShadowMap always used the geometry object from object.geometry (which could be of type THREE.Geometry).

However, now that you have mentioned it....it's actually not hard to use the converted instance of BufferGeometry which should make the PR more robust! Please check out the last commit. The code is now definitely more correct than before 👍

@mrdoob mrdoob merged commit e2364f2 into mrdoob:dev Apr 6, 2020
@mrdoob
Copy link
Owner

mrdoob commented Apr 6, 2020

Thanks!

@Mugen87 Mugen87 changed the title WebGLShadowMap: Stop support of Geometry when using morph targets. WebGLShadowMap: Simplify morph target check. Apr 6, 2020
@Mugen87 Mugen87 changed the title WebGLShadowMap: Simplify morph target check. WebGLShadowMap: Simplify morph targets check. Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdoob mrdoob mrdoob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r116
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @mrdoob