Update materialProperties.environment even if program doesn't change

[Oletus]

The environment map can be switched to a different image while still using the exact same shader. It's important to update materialProperties.environment in this case so that unnecessary calls to initMaterial can be avoided. Prior to this fix FPS could be halved after changing scene.environment to a different texture of the same type.

[Oletus]

@mrdoob @Mugen87 I hope this could be reviewed and merged soon, this bug had a really big impact on the performance of our app when trying to use scene.environment.

[Mugen87]

Okay, I see the issue. When Scene.environment is changed, initMaterial() is called because of the following check:

three.js/src/renderers/WebGLRenderer.js

Lines 1650 to 1652 in 7918de9

	} else if ( materialProperties.environment !== environment ) {
	initMaterial( material, scene, object );

However, since the shader program does not change, initMaterial() never updates the internal materialProperties object. So the change does make sense however I would move the line to:

three.js/src/renderers/WebGLRenderer.js

Line 1571 in 7918de9

materialProperties.fog = scene.fog;

In this way, the scene properties (fog and environment) are managed at the same place.

[mrdoob]

What @Mugen87 said. I'll merge and clean up 👍

[mrdoob]

Thanks!

[Oletus]

Thanks for the really quick turnaround on this, the cleanup makes sense! 👍