Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples /misc/controls/transform: Change wrong keyup (Ctrl, 17) to Shift(16) #19069

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Examples /misc/controls/transform: Change wrong keyup (Ctrl, 17) to Shift(16) #19069

merged 1 commit into from
Apr 8, 2020

Conversation

Gllloria
Copy link
Contributor

@Gllloria Gllloria commented Apr 7, 2020

Should snap to grid while pressing Shift, therefore Shift keyup should disable snapping.

@Gllloria
Correct wrong keyup (Ctrl, 17) to Shift(16)
ad01cf9 
Should snap to grid while pressing Shift, therefore Shift keyup should disable snapping.
@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 7, 2020

Thanks for fixing this! Totally overlooked in #18191.

@mrdoob mrdoob added this to the r116 milestone Apr 8, 2020
@mrdoob mrdoob merged commit 1551cf9 into mrdoob:dev Apr 8, 2020
@mrdoob
Copy link
Owner

mrdoob commented Apr 8, 2020

Thanks!

@Gllloria Gllloria deleted the patch-1 branch May 18, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r116
Development

Successfully merging this pull request may close these issues.
3 participants
@Gllloria @Mugen87 @mrdoob