Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples-Loaders: move to es6 class syntax #19073

Closed
wants to merge 1 commit into from
Closed

Examples-Loaders: move to es6 class syntax #19073

wants to merge 1 commit into from

Conversation

DefinitelyMaybe
Copy link
Contributor

related: #19061

This PR should not be pulled unless the related PR is merged first.

Various Loaders were not included in the init commit because of the following:
-global namespace pollution if anon functions unwrapped
-possible name collisions or issues (KhronosTextureContainer, MaterialCreator...)

The webgl_loader_texture_rgbm example did not use a loader.

@munrocket
Copy link
Contributor

Tests is ok here.

@mrdoob
Copy link
Owner

mrdoob commented Apr 9, 2020

examples/js are supposed to work with "old" browsers.
examples/jsm could move to classes, but I don't know what's the right way of doing it yet.

@mrdoob mrdoob closed this Apr 9, 2020
@DefinitelyMaybe
Copy link
Contributor Author

Well, there might be a bit of a mess to sort out here then. As far as I've understood (and used) thus far, the modularize.js script is used to generate the files in examples/jsm/, so there isn't a 'lets move examples/jsm to classes' without disjointing those two folders.

Meanwhile there's this comment from last year about how support for old browsers could be handled.

From a project managers perspective, I'd assume there's the contention between new development and there potential unintended consequences of said new development but until someone can throw around some solid numbers or tests or research or something, it's all hearsay. If angry/disappointment/upset emails/messages are the only sample of which decisions are made, you will never get anywhere. Someone will always be upset over something.

@mrdoob
Copy link
Owner

mrdoob commented Apr 10, 2020

If angry/disappointment/upset emails/messages are the only sample of which decisions are made, you will never get anywhere.

We have crossed similar bridges in the past. We'll figure it out.

@donmccurdy
Copy link
Collaborator

examples/js are supposed to work with "old" browsers.

@mrdoob I take it you'd prefer not to break that compatibility with old browsers between now and the deletion of this folder?

@mrdoob
Copy link
Owner

mrdoob commented Apr 11, 2020

@mrdoob I take it you'd prefer not to break that compatibility with old browsers between now and the deletion of this folder?

Yeah, I think it's better if things suddenly not work at all than kind of work.

@DefinitelyMaybe DefinitelyMaybe deleted the examples-loaders--move-to-es6-class-syntax branch June 6, 2020 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants