Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS3DRenderer: improve visible consistance #19098

Merged
merged 2 commits into from
Apr 10, 2020
Merged

CSS3DRenderer: improve visible consistance #19098

merged 2 commits into from
Apr 10, 2020

Conversation

troy351
Copy link
Contributor

@troy351 troy351 commented Apr 10, 2020 •
edited
Loading

Just like CSS2DRenderer

three.js/examples/jsm/renderers/CSS2DRenderer.js

Line 98 in d52b092

element.style.display = ( object.visible && vector.z >= - 1 && vector.z <= 1 ) ? '' : 'none';

@mrdoob mrdoob added this to the r116 milestone Apr 10, 2020
@mrdoob mrdoob merged commit 8766744 into mrdoob:dev Apr 10, 2020
@mrdoob
Copy link
Owner

mrdoob commented Apr 10, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r116
Development

Successfully merging this pull request may close these issues.
3 participants
@troy351 @mrdoob @Mugen87