Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fine tuning #19143

Merged
merged 1 commit into from
Apr 15, 2020
Merged

CI: fine tuning #19143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,7 @@ jobs:
with:
path: ~/.npm
key: ${{ runner.os }}-ci-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-ci-${{ env.cache-name }}-
${{ runner.os }}-ci-
${{ runner.os }}-
restore-keys: ${{ runner.os }}-ci-${{ env.cache-name }}-
- name: Install packages
run: npm ci

Expand All @@ -54,10 +51,7 @@ jobs:
with:
path: ~/.npm
key: ${{ runner.os }}-ci-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-ci-${{ env.cache-name }}-
${{ runner.os }}-ci-
${{ runner.os }}-
restore-keys: ${{ runner.os }}-ci-${{ env.cache-name }}-
- name: Install packages
run: npm ci

Expand Down Expand Up @@ -87,10 +81,7 @@ jobs:
with:
path: ~/.npm
key: ${{ runner.os }}-ci-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-ci-${{ env.cache-name }}-
${{ runner.os }}-ci-
${{ runner.os }}-
restore-keys: ${{ runner.os }}-ci-${{ env.cache-name }}-
- name: Install packages
run: npm ci && sudo apt-get install xvfb && npm run build

Expand All @@ -114,10 +105,7 @@ jobs:
with:
path: ~/.npm
key: ${{ runner.os }}-ci-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-ci-${{ env.cache-name }}-
${{ runner.os }}-ci-
${{ runner.os }}-
restore-keys: ${{ runner.os }}-ci-${{ env.cache-name }}-
- name: Install packages
run: npm ci

Expand Down
Binary file modified examples/screenshots/webgl2_multisampled_renderbuffers.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions test/e2e/puppeteer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ const exceptionList = [
'webgl_kinect', // same here
'webaudio_visualizer', // audio can't be analyzed without proper audio hook
'webgl_loader_texture_pvrtc', // not supported in CI, useless
'webgl_materials_envmaps_parallax',
'webgl_materials_envmaps_parallax', // empty for some reason
'webgl_test_memory2', // gives fatal error in puppeteer
'webgl_tiled_forward', // exception for Github Actions
'webgl_worker_offscreencanvas', // in a worker, not robust
'webgl2_multisampled_renderbuffers'

].concat( ( process.platform === "win32" ) ? [

Expand Down