Examples: Modularize JSZip. #19201
Merged
Examples: Modularize JSZip. #19201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix some ongoing troubles with
JSZip. From now on, the loaders in thejsmdirectory and thus the examples use the module version ofJSZip.In this way, no global import is necessary anymore:tada:. Meaning, the
three.jsversion will not clash with more modern versions ofJSZipafter this change. The module version representsJSZipin version2.6.0which was the last version which a sync interface.The PR changes some bits in the editor as well as
3MFLoader,AMFLoaderandKMZLoader.