Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebXRManager: Dynamically update camera list. #19217

Merged
merged 1 commit into from
Apr 25, 2020
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 25, 2020

Fixed #19071.
Fixed #18525.

This PR ensures that the number of WebXRManager's internal cameras (cameraVR.cameras) always matches the actual number of available WebXR views.

Tested AR and VR examples on a Pixel.

@mrdoob mrdoob added this to the r116 milestone Apr 25, 2020
@mrdoob mrdoob merged commit ae282bc into mrdoob:dev Apr 25, 2020
@mrdoob
Copy link
Owner

mrdoob commented Apr 25, 2020

Nice! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebXR seems to render everything twice for immersive-ar WebXR AR session after VR session has extra camera
2 participants