-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPGPU birds example with GLTF loader and MeshStandardMaterial #19318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I reloaded and saw the flocking horses: 🤯 😍
This is really cool, great work.
examples/webgl_gpgpu_birds.html
Outdated
|
||
var token = '#define STANDARD'; | ||
var insert = 'attribute vec4 reference;'; | ||
insert += 'attribute vec4 seeds;'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section would be nicer written as a template string. @Mugen87 do we allow these in examples yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we can use template strings in examples. They're using modules anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@santi-grau can you change this to use template strings?
var insert = /* glsl */`
attribute vec4 reference;
attribute vec4 seeds;
attribute vec3 birdColor;
uniform sampler2D texturePosition;
...
`;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! will look into all this during the weekend :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put all the 'replacement' strings into a template string. Hope this is what you meant. :S
Santiii! Mola!! 🤩 |
Thanks! |
Okay, mrdoob just merged the commit without screenshot. Prepare to bugs in a repo. |
Sorry guys, I'm really new to collaborating on github, I normally work on small stuff on my own. Is there anything I can do to help? |
We are new too, the problem that reviewers don’t care. That’s all :D |
@santi-grau Don't worry! I'll take care of it 👌 |
@Mugen87 Thanks! |
Demo here :
https://uber-gpgpu-demo.glitch.me
This is my first PR ever. Not sure if this is even helpful or correctly done but would like to learn the process to contribute to three in the future.