FBXLoader: Account for invalid parseAnimationLayers children IDs #19368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems to be connections with null relationships
mrdoob
reviewed
May 15, 2020
examples/js/loaders/FBXLoader.js
Outdated
| @@ -2491,6 +2491,11 @@ THREE.FBXLoader = ( function () { | |||
| if ( modelID !== undefined ) { | |||
|
|
|||
| var rawModel = fbxTree.Objects.Model[ modelID.toString() ]; | |||
|
|
|||
| if (!rawModel) { | |||
There was a problem hiding this comment.
This makes the code more readable:
if ( rawModel === undefined ) {
mrdoob
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some of my FBX files, a few of the relationships point to objects without any relationship data. As a result, parseAnimationLayers crashes when accessing
fbxTree.Objects.Model[ modelID.toString() ]and the FBX fails to parse.Here are a few sample FBX that fail to parse as a result of the invalid data. The files were generated with Unity's FBX Exporter plugin, but are valid in every other FBX viewer or importer I have.
https://hypermesh-staging.accelerator.net/dev/performances/eeh5Y6?download=BNN-E021-A007.fbx (63MB)
https://hypermesh-staging.accelerator.net/dev/performances/XdhjOd?download=BNN-E021-A010.fbx (28MB)
Let me know if I can be of any help testing, or providing more detail. This goes more low-level than I'm familiar with, so I'm not sure if the bug is better fixed on a helper level. I've also left debugging log in there, as I figured it helps highlight the problem.