Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWOLoader: dev branch factorization #19378

Merged
merged 1 commit into from
May 17, 2020
Merged

Conversation

sciecode
Copy link
Contributor

This PR intends to return LWO main development branch to three.js and extend a factorization scheme per discussed on threejs/lwoloader#24

It does not include update to typescript definition per module import, which I think might be necessary. If it is, I would like to request help from someone more familiar with it, as my version would likely be useless.

discussion
I would like to just briefly discuss my opinion on the failed approach of trying to maintain a separated dev repository from Three.js. Having an autonomous control of development is beneficial, but having to keep both Three.js version and Dev branch files synchronized proved to be a bigger burden.

If we were to try a similar approach for other loaders in the future, I would strongly recommend using git submodule approach where the entire development is also moved to a different repository.

@mrdoob mrdoob added this to the r117 milestone May 17, 2020
@mrdoob mrdoob merged commit 8536e97 into mrdoob:dev May 17, 2020
@mrdoob
Copy link
Owner

mrdoob commented May 17, 2020

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented May 17, 2020

If we were to try a similar approach for other loaders in the future, I would strongly recommend using git submodule approach where the entire development is also moved to a different repository.

One downside of submodules is that when you download the repo as a zip file submodules are not included. Or at least that used to be the case years ago.

@looeee
Copy link
Collaborator

looeee commented May 17, 2020

git clone --recurse-submodules will clone with submodules. But I don't think there's any way to download them in the zip.

Here are the previous discussion related to the LWOLoader being in a separate repo:
#16679 #16678

@sciecode sciecode deleted the dev-lwoloader-factor branch May 17, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants