LWOLoader: dev branch factorization #19378
Merged
+2,024
−5,040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to return LWO main development branch to three.js and extend a factorization scheme per discussed on threejs/lwoloader#24
It does not include update to typescript definition per module import, which I think might be necessary. If it is, I would like to request help from someone more familiar with it, as my version would likely be useless.
discussion
I would like to just briefly discuss my opinion on the failed approach of trying to maintain a separated dev repository from Three.js. Having an autonomous control of development is beneficial, but having to keep both Three.js version and Dev branch files synchronized proved to be a bigger burden.
If we were to try a similar approach for other loaders in the future, I would strongly recommend using
git submodule
approach where the entire development is also moved to a different repository.