TS: Prefer union arguments to overloads for simple cases #19403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around microsoft/TypeScript#14107
In my typescript project I accept config for colors as
color: string | number
but using that with threejs can be a fiddle in some cases:I searched the codebase for overloads using
( +)(\w+)\(.+\n\1\2\(
and it looks likeColor
is pretty much the only unnecessary use of overloads so have fixed all those which I found.I cannot see any typescript tests besides lint so I have't tried to add any.