TS: Clean up. #19529
Merged
TS: Clean up. #19529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrdoob Should deprecated method or function parameters always be removed from the TS declaration? I'm not sure this was ever discussed. This PR removes |
|
Yes, I think d.ts files should not have deprecated stuff. |
|
@linbingquan Okay, in this case |
OK. How about it three.js/src/geometries/TubeGeometry.js Line 33 in a24d211 |
Mugen87
reviewed
Jun 3, 2020
linbingquan
force-pushed
the
dev-cleanup-ts
branch
from
f82cfb7 to
408d5fa
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a little hard to found...