Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLRenderer render method type definition: accept Object3D as first argument #19564

Merged
merged 2 commits into from
Jun 12, 2020
Merged

WebGLRenderer render method type definition: accept Object3D as first argument #19564

merged 2 commits into from
Jun 12, 2020

Conversation

martinRenou
Copy link
Contributor

@martinRenou martinRenou commented Jun 5, 2020 •
edited
Loading

fix #19563

@martinRenou martinRenou changed the title WebGLRenderer render method: accept Object3D as first argument WebGLRenderer render method type definition: accept Object3D as first argument Jun 5, 2020
@Mugen87 Mugen87 added this to the r118 milestone Jun 12, 2020
@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 12, 2020

@mrdoob This PR seems good to go.

@mrdoob
Copy link
Owner

mrdoob commented Jun 12, 2020

Scene extends Object3D.

@martinRenou
Copy link
Contributor Author

What do you mean @mrdoob ?

@martinRenou
WebGLRenderer render method: accept Object3D as first argument
bd28175 
Signed-off-by: martinRenou <martin.renou@gmail.com>
@martinRenou
Copy link
Contributor Author

I also noticed the compile method which has the same signature as render, can it accept any kind of Object3D as well? Should I update it?

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 12, 2020

I would say yes.

@martinRenou
WebGLRenderer compile method: accept Object3D as first argument
e0ff902 
Signed-off-by: martinRenou <martin.renou@gmail.com>
@martinRenou
Copy link
Contributor Author

Done. Please tell me if you need any other change.

@mrdoob mrdoob merged commit ad326f0 into mrdoob:dev Jun 12, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jun 12, 2020

Thanks!

@martinRenou martinRenou deleted the render_input branch June 13, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r118
Development

Successfully merging this pull request may close these issues.

WebGLRenderer render type definition
3 participants
@martinRenou @Mugen87 @mrdoob