Added handler for dark mode #19604
Added handler for dark mode #19604
Conversation
Aelof3
commented
Jun 9, 2020
Aelof3
commented
- Added style block to head via javascript
- Added listener to update color scheme when changed in parent
- Added style block to head via javascript - Added listener to update color scheme when changed in parent
| head.appendChild(style); | ||
|
|
||
| if ( style.styleSheet ){ | ||
| // This is required for IE8 and below. |
There was a problem hiding this comment.
I don't think we need to support IE8.
|
Related: #19603 |
|
What is the relation between this PR and #19603? |
|
this modifies index.html to modify the color scheme, and sends a ping to the page.js in #19603 where it updates the color scheme for the doc loaded in the viewer iframe |
|
Doesn't it make more sense to bundle everything into a single PR? It's very unusual to create a PR for each modified file. |
|
gonna be honest, this is my first change to a repo other than my own and I have no idea how to do that |
|
How have to created the PR? By forking the repo on you computer or via the GitHub UI? |
|
Used the edit file button on the GitHub UI, which forked it for me I am pretty sure |
|
It's just important that you change all files in the same branch. Then you can submit a single PR with all changes. I suggest you study a bit the contribution guide and try it again: https://github.com/mrdoob/three.js/blob/dev/.github/CONTRIBUTING.md#contribution One major problem right now is that's in not possible to test your changes. When changes are split over PRs, there is no convenient way to verify what you do. |
|
I see, I will close this and the other one and see what I can do |
