Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageUtils.getDataURL(): A dataurl is already a dataurl #19630

Merged
merged 4 commits into from
Jun 12, 2020
Merged

ImageUtils.getDataURL(): A dataurl is already a dataurl #19630

merged 4 commits into from
Jun 12, 2020

Conversation

gero3
Copy link
Contributor

@gero3 gero3 commented Jun 11, 2020

Serializing a texture with a data URL as src to JSON takes a long time.

To Reproduce:

Issue

-It tries to recreate the data URL when it already exists

Solution

  • Check if it is already a data URL as src

@mrdoob
Copy link
Owner

mrdoob commented Jun 12, 2020

Nice catch!

@mrdoob mrdoob added this to the r118 milestone Jun 12, 2020
@mrdoob mrdoob changed the title A dataurl is already a dataurl ImageUtils: A dataurl is already a dataurl Jun 12, 2020
@mrdoob mrdoob changed the title ImageUtils: A dataurl is already a dataurl ImageUtils.getDataURL(): A dataurl is already a dataurl Jun 12, 2020
@mrdoob mrdoob merged commit c1f75d7 into mrdoob:dev Jun 12, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jun 12, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r118
Development

Successfully merging this pull request may close these issues.
2 participants
@gero3 @mrdoob