Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Updated index.html #19636

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Docs: Updated index.html #19636

merged 1 commit into from
Jun 12, 2020
+2 −3

Conversation

linbingquan
Copy link
Contributor

No description provided.

@linbingquan linbingquan changed the title Updated: index.html Docs: Updated index.html Jun 12, 2020
Mugen87
Mugen87 reviewed Jun 12, 2020
View reviewed changes
files/main.css
@@ -257,7 +257,6 @@ h1 a {
#panel #language {
font-family: 'Roboto Mono', monospace;
font-size: 1rem;
line-height: 1rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um, why is this line changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um, why is this line changed?

Sorry, I didn't compare the result. Here you are.

Before After
before_en after_en
before_zh after_zh

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, so this is required because changing from en to English requires more space.

@mrdoob mrdoob added this to the r118 milestone Jun 12, 2020
@mrdoob mrdoob merged commit 09f0af1 into mrdoob:dev Jun 12, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jun 12, 2020

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Jun 12, 2020

This breaks the design in Safari a bit:

Screen Shot 2020-06-12 at 11 55 17 AM

Screen Shot 2020-06-12 at 11 54 12 AM

Chinese people don't like zh?

@linbingquan
Copy link
Contributor Author

This breaks the design in Safari a bit:

I am work in Windows 10 OS. The breaks is e is not capitalization? but I felt confused after saw this commit 06bbffe.

three.js/docs/index.html

Line 33 in 330d29d

<option value="en">english</option>

Chinese people don't like zh?

It's not intuitive.

I saw the React and Vue website translations also use native language.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 13, 2020 •
edited
Loading

TBH, I find the new English term misleading. It looks like it's already a search term. The previous approach was less obtrusive and still understandable.

@mrdoob
Copy link
Owner

mrdoob commented Jun 20, 2020

How about "en" and "中文"? 1af3252

@linbingquan linbingquan deleted the dev-docs branch July 24, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r118
Development

Successfully merging this pull request may close these issues.
3 participants
@linbingquan @mrdoob @Mugen87