Examples: Thumbnails index page #19644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oooh, that's ******* cool. I think that's better than having them in the sidebar. Makes the sidebar hard to navigate. But this gives two options: use the sidebar like before (not a breaking change for user experience) and see more thumbnails at once in the main area. |
trusktr
approved these changes
Jun 14, 2020
Collaborator
|
With regard to #19375 (comment), it seems design related PRs should not be created anymore. |
Collaborator
|
This seems to be the best solution to me. It works well on mobile and desktop, and it keeps the list and the thumbnails so everyone should be happy. |
The live site at https://threejs.org/examples the history does not work correctly. This change fixes it for this new show lots of thumbnails version
greggman
force-pushed
the
fruit-on-the-bottom
branch
from
1a56498 to
b7a3ba3
Compare
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure if you wanted this or not.