Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: Properly specify texture sRGB encoding #19800

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Examples: Properly specify texture sRGB encoding #19800

merged 1 commit into from
Aug 14, 2020

Conversation

WestLangley
Copy link
Collaborator

... plus some clean up.

I also added an inline note regarding the encoding for render target textures:

encoding: THREE.sRGBEncoding // temporary -- to prevent the material's shader from recompiling every frame

@WestLangley WestLangley added this to the r119 milestone Jul 6, 2020
@mrdoob mrdoob modified the milestones: r119, r120 Jul 29, 2020
@mrdoob mrdoob merged commit 4e50d8d into mrdoob:dev Aug 14, 2020
@mrdoob
Copy link
Owner

mrdoob commented Aug 14, 2020

Thanks!

@WestLangley WestLangley deleted the dev_examples_cubemap branch August 14, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

@mrdoob mrdoob mrdoob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r120
Development

Successfully merging this pull request may close these issues.
3 participants
@WestLangley @mrdoob @Mugen87