New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: make loadFile in UITexture works correctly #19838

Merged

mrdoob merged 1 commit into mrdoob:dev from troy351:patch-3

Jul 15, 2020

Contributor

troy351 commented Jul 14, 2020

TGA files may not have type property when load from input, current check logic could fail, check through extension now
Should transform file extension into lower case before compare, that current hdr file check could fail
Should always clear the texture preview canvas before set new one, because new texture may contains transparency


          Editor: refactor loadFile logic in UITexture

121f7dc

troy351 changed the title ~~Editor: refactor loadFile logic in UITexture~~ Editor: make loadFile in UITexture works correctly

mrdoob added this to the r119 milestone

mrdoob merged commit 8419bf3 into mrdoob:dev

Owner

mrdoob commented Jul 15, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet