Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS: fixed GridHelper types #19870

Merged
merged 1 commit into from
Jul 19, 2020
Merged

TS: fixed GridHelper types #19870

merged 1 commit into from
Jul 19, 2020

Conversation

ycw
Copy link
Contributor

@ycw ycw commented Jul 19, 2020

accept css names of type string for color1 and color2

@ycw
fixed GridHelper types
594e778 
accept css names of type string for `color1` and `color2`
@WestLangley WestLangley changed the title fixed GridHelper types TS: fixed GridHelper types Jul 19, 2020
@WestLangley WestLangley added this to the r119 milestone Jul 19, 2020
@mrdoob mrdoob merged commit b5c272c into mrdoob:master Jul 19, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jul 19, 2020

Thanks!

@ycw ycw deleted the patch-3 branch July 19, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r119
Development

Successfully merging this pull request may close these issues.
4 participants
@ycw @mrdoob @Mugen87 @WestLangley