Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLMaterials: Avoid undefined as maxMipLevel uniform value. #19882

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 20, 2020

Related #19878.

__maxMipLevel is only computed when the env map is fully loaded and uploaded to the GPU. This fix avoids setting undefined.

@mrdoob mrdoob added this to the r119 milestone Jul 20, 2020
@mrdoob mrdoob merged commit a03577e into mrdoob:dev Jul 20, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jul 20, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants