Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoTexture: Make use of requestVideoFrameCallback(). #19906

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 22, 2020

Replacement of #19905.

This makes the WebGL warnings in webgl_video_panorama_equirectangular go away.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 22, 2020

As mentioned here #19905 (comment), when the support of requestVideoFrameCallback() gets better, VideoTexture.update() can be removed.

Current support status: https://caniuse.com/#search=requestVideoFrameCallback

@mrdoob mrdoob added this to the r119 milestone Jul 22, 2020
@mrdoob mrdoob merged commit cd139a5 into mrdoob:dev Jul 22, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jul 22, 2020

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Jul 22, 2020

Feels good to only update video textures when needed. Finally...

@mrdoob
Copy link
Owner

mrdoob commented Jul 22, 2020

@greggman do you think I should revert 95db034?

@greggman
Copy link
Contributor

greggman commented Jul 22, 2020

No I don't think so you should revert it. This 95db034 a different issue than #19905

@greggman
Copy link
Contributor

Or maybe revert is the wrong suggestion. originally it was arguably wrong in that the event it was waiting for could have already happened. Maybe with the new fix it doesn't need the event at all?

@mrdoob
Copy link
Owner

mrdoob commented Jul 23, 2020

Or maybe revert is the wrong suggestion. originally it was arguably wrong in that the event it was waiting for could have already happened. Maybe with the new fix it doesn't need the event at all?

Yes, that's what I meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants