Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeBuilder: fix optional method arguments in TypeScript definitions #19963

Merged
merged 1 commit into from
Jul 30, 2020
Merged

NodeBuilder: fix optional method arguments in TypeScript definitions #19963

merged 1 commit into from
Jul 30, 2020

Conversation

martinRenou
Copy link
Contributor

No description provided.

@martinRenou
NodeBuilder: fix optional method arguments in TypeScript definitions
0e66654 
Signed-off-by: martinRenou <martin.renou@gmail.com>
@mrdoob mrdoob added this to the r120 milestone Jul 30, 2020
@mrdoob mrdoob requested a review from sunag July 30, 2020 08:27
sunag
sunag approved these changes Jul 30, 2020
View reviewed changes
Copy link
Collaborator

@sunag sunag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrdoob mrdoob merged commit 3ca8069 into mrdoob:dev Jul 30, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jul 30, 2020

Thanks!

@martinRenou martinRenou deleted the nodebuilder_parscode branch July 30, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunag sunag sunag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r120
Development

Successfully merging this pull request may close these issues.
3 participants
@martinRenou @mrdoob @sunag