WebGLProgram: make unroll loop regexp accept other coding style #20012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It often happens that my loop don't get unrolled because my coding style isn't as aired as the one from Three.js. Nothing fancy but this should allow to unroll loops like:
We can obviously go much more crazy and authorize
++i
or whatever, but I believe at least the brackets position is important, otherwise colleagues start to fix shaders coding style and no unrolling occurs 😄Other potential fix would be to do the unrolling directly in my codebase.