math area and space: move to es6 classes #20076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yomotsu
commented
Aug 15, 2020
|
|
||
| const _vector = new Vector3(); | ||
|
|
||
| const _box = new Box3(); |
There was a problem hiding this comment.
internal values have been moved to the end of the file, since this line was calling Box3 itself.
|
oooh yeah! 👍 |
Closed
43 tasks
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of #19986
This PR contains:
Sphericalhas been done by another PRBasic math classes have been done by #19997
I have checked the examples folder randomly and it works correctly.