Audio: Introduce _connected flag to fix setFilters bug #20093
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem this PR fixes
Audio.setFilters()
resets connection by calling.disconnect()
and.connect()
if.isPlaying
istrue
.The problem is
Audio
status can be "connected but.isPlaying
isfalse
". In that case connection won't be reset and then filters won't be applied.The examples of "connected but
.isPlaying
isfalse
"..setNodeSource()
,setMediaElementSource()
, orsetMediaStreamSource()
. And not call.play()
..play()
and then call.pause()
or.stop()
.How to fix
The root issue would be that
.isPlaying
is not corresponding to "connected". So I'd like to suggest introducing a new private boolean property._connected
which is updated in.connect/disconnect()
and shows exactly whether connected or not. And letsetFilters
use it to detect whether connected or not.