-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS: Added types for WebXR #20150
TS: Added types for WebXR #20150
Conversation
I think I would move the file to |
@mrdoob I figured since it doesn't declare types for any three.js specific module, it should be put it extras. Do you think I should move it to Also, I haven't exported these types in Three.d.ts, should that be done? Would it be useful? |
I think so yes.
No idea, I have no experience with Typescript... |
Looking good! Just a few linting warnings. Are these fixable? |
Yeah, fixed. |
Thanks! |
Added types for WebXR and fixed object types in WebXR related declaration files.
Related to issue #20041
Types are adapted from these files.