Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS: Update LineSegments #20295

Merged
merged 2 commits into from
Sep 10, 2020
Merged

TS: Update LineSegments #20295

merged 2 commits into from
Sep 10, 2020

Conversation

ycw
Copy link
Contributor

@ycw ycw commented Sep 8, 2020

remove 3rd param, mode is redundant.
prop type is always "LineSegments", so use literal type is sufficient.

remove 3rd param, `mode` is redundant.
prop `type` is always "LineSegments", so use literal type is sufficient.
@mrdoob
Copy link
Owner

mrdoob commented Sep 9, 2020

Seems like this PR is creating a bunch of linting issues?
https://github.com/mrdoob/three.js/pull/20295/files

@ycw
Copy link
Contributor Author

ycw commented Sep 9, 2020

LineSegments is the base type of bunch of helpers which do change the prop type, so the old one is fine.

LineSegments.d.ts

type : 'LineSegments' | string

@Mugen87 Mugen87 changed the base branch from master to dev September 9, 2020 12:57
@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 9, 2020

@ycw Please always target the dev branch when making PRs.

@ycw
Copy link
Contributor Author

ycw commented Sep 9, 2020

my bad.

@mrdoob mrdoob added this to the r121 milestone Sep 10, 2020
@mrdoob mrdoob merged commit ef47b33 into mrdoob:dev Sep 10, 2020
@mrdoob mrdoob changed the title update LineSegments.d.ts TS: Update LineSegments Sep 10, 2020
@mrdoob
Copy link
Owner

mrdoob commented Sep 10, 2020

Thanks!

@ycw ycw deleted the patch-3 branch September 11, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants