Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in PointerLockControls example. #20334

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Fixed bug in PointerLockControls example. #20334

merged 1 commit into from
Sep 14, 2020

Conversation

arodic
Copy link
Contributor

@arodic arodic commented Sep 13, 2020

There was a "camera teleport" bug with example caused by prevTime and time being updated only while controls.isLocked === true. The bug can be reproduced by pressing and holding any of the WASD keys before clicking to lock controls.

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 13, 2020

This potentially fixes #20329 also.

Unfortunately, it does not. I've already tested this option today.

https://raw.githack.com/io-gui/three.js/pointerlock/examples/misc_controls_pointerlock.html

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 13, 2020

This PR actually breaks PointerLockControls in Safari, see #20161 (comment).

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 13, 2020

Reverted Safari fix for event.movement in TrackballControls

You also have to revert the changes from the file in examples/js. Besides, you've edited not TrackballControls but PointerLockControls 😉 .

Consider to reset your changes and force-push a new, single and clean commit.

@arodic
Copy link
Contributor Author

arodic commented Sep 13, 2020

I will revert the change entirely and leave example fix only.

So movementX/Y does not work in Safari at all?

@arodic arodic changed the title Converted PointerLockControls to pointer events. Improved example. Fixed bug in PointerLockControls example. Sep 13, 2020
@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 13, 2020

So movementX/Y does not work in Safari at all?

At least not in context of Pointer Events right now.

@Mugen87 Mugen87 added this to the r121 milestone Sep 13, 2020
@mrdoob mrdoob merged commit fad6ce2 into mrdoob:dev Sep 14, 2020
@mrdoob
Copy link
Owner

mrdoob commented Sep 14, 2020

Thanks!

@arodic arodic deleted the pointerlock branch April 19, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants