Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Update esprima 2.0 to 3.1 #20425

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Editor: Update esprima 2.0 to 3.1 #20425

merged 1 commit into from
Sep 28, 2020

Conversation

devingfx
Copy link
Contributor

Related issues:

#20417

Description

As discussed in the issue an update of esprima permit the user of editor to write ES classes in Script panel.

Mugen87
Mugen87 approved these changes Sep 28, 2020
View reviewed changes
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this change with a few scripts and indeed the usage of classes works now without issues. The "Publish" feature also works with this change.

@mrdoob mrdoob added this to the r121 milestone Sep 28, 2020
@mrdoob mrdoob merged commit 81a52c3 into mrdoob:dev Sep 28, 2020
@mrdoob
Copy link
Owner

mrdoob commented Sep 28, 2020

Thanks!

@Mugen87 Mugen87 mentioned this pull request Sep 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r121
Development

Successfully merging this pull request may close these issues.
3 participants
@devingfx @mrdoob @Mugen87