Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS: Fix "color" property type on LineBasicMaterial #20429

Merged
merged 3 commits into from
Sep 28, 2020
Merged

TS: Fix "color" property type on LineBasicMaterial #20429

merged 3 commits into from
Sep 28, 2020

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Sep 28, 2020 •
edited
Loading

Description

The color property can only be a Color, it can't be a string or number.

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 28, 2020

I'm afraid this is not true: https://jsfiddle.net/r0z3b1pw/2/

@Methuselah96
Copy link
Contributor Author

Methuselah96 commented Sep 28, 2020 •
edited
Loading

@Mugen87 Sorry, I got too ambitious. The property on the class is still just a Color though I believe. Updated my PR.

Mugen87
Mugen87 approved these changes Sep 28, 2020
View reviewed changes
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right 👍 .

@Mugen87 Mugen87 added this to the r121 milestone Sep 28, 2020
@mrdoob mrdoob changed the title Fix "color" property type on LineBasicMaterial TS: Fix "color" property type on LineBasicMaterial Sep 28, 2020
@mrdoob mrdoob merged commit b1390eb into mrdoob:dev Sep 28, 2020
@mrdoob
Copy link
Owner

mrdoob commented Sep 28, 2020

Thanks!

@Methuselah96 Methuselah96 deleted the patch-1 branch September 28, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r121
Development

Successfully merging this pull request may close these issues.
3 participants
@Methuselah96 @Mugen87 @mrdoob