Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fix ViewHelper with translated camera. #20524

Merged
merged 1 commit into from
Oct 17, 2020
Merged

Editor: Fix ViewHelper with translated camera. #20524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions editor/js/Viewport.ViewHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,12 @@ function ViewHelper( editorCamera, container ) {
this.update = function ( delta ) {

var step = delta * turnRate;
var focusPoint = this.controls.center;

// animate position by doing a slerp and then scaling the position on the unit sphere

q1.rotateTowards( q2, step );
editorCamera.position.set( 0, 0, 1 ).applyQuaternion( q1 ).multiplyScalar( radius );
editorCamera.position.set( 0, 0, 1 ).applyQuaternion( q1 ).multiplyScalar( radius ).add( focusPoint );

// animate orientation

Expand Down Expand Up @@ -258,7 +259,7 @@ function ViewHelper( editorCamera, container ) {
//

radius = editorCamera.position.distanceTo( focusPoint );
targetPosition.multiplyScalar( radius );
targetPosition.multiplyScalar( radius ).add( focusPoint );

dummy.position.copy( focusPoint );

Expand Down