-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLTFLoader: Add support for EXT_texture_webp. #20539
Conversation
I would like to test (and review). Do you or someone else have glTF file including EXT_texture_webp extension? |
Sure, here are two examples:
^Ideally the "fallback" PNG would not be bundled in the same file as the WebP texture, so you only have to download one or the other, but this is a quick test. :) |
can https://aomediacodec.github.io/av1-avif/ be included in the same way? |
I don't think anyone has proposed a third-party extension for AVIF yet. The browser support is pretty limited, as well: https://caniuse.com/avif. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented two nits, but this change is looking good to me and I confirmed it works on my Windows Chrome and Firefox.
Updated to address feedback, thanks @takahirox and @zeux! |
Thanks! |
Adds support for WebP images in glTF models.
https://caniuse.com/webp