ColladaLoader: Use Object3D.animations. #20767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #20738
Description
Since
Object3D.animations
is now available, I suggest to migrate all loaders to use the new property (FBXLoader
already uses this approach). In this way, no separate property in the result object is necessary anymore. Besides, the editor (and potentially other software) can lookup animation clips at a common place.The change in
ColladaLoader
is backwards compatible by introducing a getter for the oldanimations
property. This could be removed after a few releases.If the PR gets merged, I'll change the remaining loaders in the same fashion.