-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual: added importmap support #23371
Conversation
Ops! Could you resolve the conflicts? |
@mrdoob I'm not sure how to 455 conflicts.. |
A few comments:
|
it seems a generated form is sent to external domains, true?
import-maps is a draft, esms is influx, hard coding map and polyfill in many places is not a good idea for now.
I thought the examples are data files for the editor, the sources (html/css/js) have been clearly displayed in each pane. I'm not sure what the motivation of 'open in separate window'. ( wait..., is the popup window in sync with the editor in realtime? )
I agree, I might PR this. |
Closing. Please split up your changes into smaller PRs. |
Related issue: #23363
added importmap in two files (here, there)
transform assets' path from abs to rel; asset includes script,link,iframe,img in manual//.html and manual//.js
iframe is sandboxed ( forbid export-to, and open-external, those buttons are noop, for now )
use es-module-shim shim-mode, no errors will be prompted.
Preview: