Add OrbitControls connect method

[alexandernanberg]

Related issue: #20575

Description

Add a connect method which will perform the side-effects (attach event listeners). Backwards compatibility is kept but a warning message is logged.

connect with dispose sounds a bit weird. connect + disconnect feels more natural but dispose is what you commonly use. Happy to bike-shed more about naming

I'll fix the remaining todo's once I get an OK on the change

TODO

• Update docs
• Update examples

[LeviPesin]

connect with dispose sounds a bit weird. connect + disconnect feels more natural but dispose is what you commonly use. Happy to bike-shed more about naming

Maybe make a function disconnect and just do this.dispose = this.disconnect? Then in other controls a similar pattern could be used - making functions connect and disconnect and calling disconnect (with some other code, possibly) from dispose.

[LeviPesin]

So please remove the warning from the dispose function.

[alexandernanberg]

Done! However I think dispose should always just be an alias of disconnect, I don't think there should be 2 clean up fns for controllers, but it's up to you I guess.

[Mugen87]

I don't think it's necessary to update the examples. However adding the new methods to the documentation would be great!

[Mugen87]

https://rawcdn.githack.com/alexandernanberg/three.js/orbitcontrols-connect/examples/misc_controls_orbit.html

[alexandernanberg]

I've updated the docs now, let me know what you think!

[LeviPesin]

@Mugen87 Will this PR be a part of the r140?

[drcmda]

this would appreciated. though it affects all controls not just orbit it would be a start.

to reiterate, constructor side effects prevent a class from being created and discarded without knowing implementation details (like dispose). any system or automatism that expects classes to be pure (which they should be) will fail.

[Mugen87]

Fixed via #29142.