-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGPU & NodeMaterial: ComputeNode #23905
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b1fe762
add ComputeNode
sunag 0253faf
fix float function parameters, support to void function
sunag 83c85c6
add StorageBufferNode
sunag bf2db82
add compute(), timer(), compute(), storage() and func() elements
sunag c0f7022
WebGPU: add StorageBufferNode and ComputeNode support and cleanup
sunag 7db9a5a
update webgpu_compute example
sunag c8570ac
cleanup
sunag d680fd9
Merge branch 'dev' into dev-gpgpu
sunag 6995822
fix ToneMappingNode in non-physical material
sunag 59bb988
fixes and cleanup
sunag 41898a6
fixes and ignore tonemapping in non physical material
sunag aceb1f9
update snapshots
sunag File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import BufferNode from './BufferNode.js'; | ||
|
||
class StorageBufferNode extends BufferNode { | ||
|
||
constructor( value, bufferType, bufferCount = 0 ) { | ||
|
||
super( value, bufferType, bufferCount ); | ||
|
||
} | ||
|
||
getInputType( /*builder*/ ) { | ||
|
||
return 'storageBuffer'; | ||
|
||
} | ||
|
||
} | ||
|
||
StorageBufferNode.prototype.isStorageBufferNode = true; | ||
|
||
export default StorageBufferNode; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
import Node from '../core/Node.js'; | ||
import { NodeUpdateType } from '../core/constants.js'; | ||
|
||
class ComputeNode extends Node { | ||
|
||
constructor( dispatchCount, workgroupSize = [ 64 ] ) { | ||
|
||
super( 'void' ); | ||
|
||
this.updateType = NodeUpdateType.Object; | ||
|
||
this.dispatchCount = dispatchCount; | ||
this.workgroupSize = workgroupSize; | ||
|
||
this.computeNode = null; | ||
|
||
} | ||
|
||
update( { renderer } ) { | ||
|
||
renderer.compute( this ); | ||
|
||
} | ||
|
||
generate( builder ) { | ||
|
||
const { shaderStage } = builder; | ||
|
||
if ( shaderStage === 'compute' ) { | ||
|
||
const snippet = this.computeNode.build( builder, 'void' ); | ||
|
||
if ( snippet !== '' ) { | ||
|
||
builder.addFlowCode( snippet ); | ||
|
||
} | ||
|
||
} | ||
|
||
} | ||
|
||
} | ||
|
||
ComputeNode.prototype.isComputeNode = true; | ||
|
||
export default ComputeNode; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be an argument in the constructor?