Examples: Depth peeling example #24227
Conversation
|
|
||
| const clonedMaterial = obj.material.clone(); | ||
| clonedMaterial.blending = THREE.NoBlending; | ||
| clonedMaterial.onBeforeCompile = ( shader ) => { |
There was a problem hiding this comment.
In the past, we've come to the conclusion to not add this kind of shader patching to the examples anymore since it easily breaks when built-in materials are changed.
#15312 also did that and it always felt like a hack. But I assume there is no other way to support depth peeling right? Meaning the technique requires a change in the shader code, correct?
There was a problem hiding this comment.
I can match void main() { and prepend the peeling codes at the beginning of the main instead of appending to the end. It should be safer than just matching }$.
There was a problem hiding this comment.
Or I can make snapshot of current(r141) MeshStandardMaterial fragment shader and embed it using ShaderMaterial? This way it won't break by any built-in material update.
There was a problem hiding this comment.
Um, I'm not yet sure what's best in this context.
There was a problem hiding this comment.
I still think void main() { match should be practically safe since those four tokens will always exist consecutively according to GLSL specification.
But I understand it's a "hack" nevertheless and your reluctance to this approach.
There was a problem hiding this comment.
Depth Peeling is simple technique yet its not easily accessible due to lack of examples. So I think it will have benefits at least to some extent for users.
There was a problem hiding this comment.
I think what @Mugen87 is suggesting is to add the depth peeling to the renderer itself rather than to create an example or class.
There was a problem hiding this comment.
@LeviPesin Yes, I understood that part. But he asked @mrdoob second opinion and I pryingly added mine 😅
There was a problem hiding this comment.
All in all, please close the PR if you guys think it's against the THREE.JS's policy. I'm happy either way 👍
Description
A very basic depth peeling implementation based on Order-Independent Transparency - NVIDIA
Control depth between 1~5
Enable/Disable
Inspired by #15312.
If possible, I would love to add DepthPeeling class into
examples/jsm/.