Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ssl in dev script #24939

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Enable ssl in dev script #24939

merged 2 commits into from
Nov 16, 2022

Conversation

DevPika
Copy link
Contributor

@DevPika DevPika commented Nov 12, 2022

Description

A quality-of-life addition which makes it easier to start a secure context for WebXR development.

Usage

npm run dev-https

@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 12, 2022

@mrdoob I'm not in favor of adding even more npm scripts. Would it be an option to use SSL by default?

@DevPika
Copy link
Contributor Author

DevPika commented Nov 12, 2022

True, there are quite a few scripts already... While I have not encountered them myself, are there any issues with using SSL by default though? Maybe situations where the encryption could get in the way while testing locally? Or maybe because of mixed content security warnings?

@mrdoob
Copy link
Owner

mrdoob commented Nov 15, 2022

Yeah, I think we can just add --ssl to the dev script instead.

@mrdoob
Copy link
Owner

mrdoob commented Nov 15, 2022

@DevPika

True, there are quite a few scripts already... While I have not encountered them myself, are there any issues with using SSL by default though? Maybe situations where the encryption could get in the way while testing locally? Or maybe because of mixed content security warnings?

There's is only one way to know 😉

@DevPika
Copy link
Contributor Author

DevPika commented Nov 15, 2022

@DevPika

True, there are quite a few scripts already... While I have not encountered them myself, are there any issues with using SSL by default though? Maybe situations where the encryption could get in the way while testing locally? Or maybe because of mixed content security warnings?

There's is only one way to know 😉

YOLO 😉

@mrdoob mrdoob changed the title Add dev-https script option Enable ssl in dev script Nov 16, 2022
@mrdoob mrdoob added this to the r147 milestone Nov 16, 2022
@mrdoob mrdoob merged commit d171cc1 into mrdoob:dev Nov 16, 2022
@Mugen87 Mugen87 mentioned this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants