Improve transmission when background is transparent #26003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
WestLangley
commented
May 7, 2023
|
|
||
| _this.getClearColor( _currentClearColor ); | ||
| _currentClearAlpha = _this.getClearAlpha(); | ||
| if ( _currentClearAlpha < 1 ) _this.setClearColor( 0x7f7f7f, 0.8 ); |
There was a problem hiding this comment.
Based on my experiments, values greater than 0x7f7f7f are too bright. This seems to be a good compromise.
The clear alpha value of 0.8 allows the CSS background to show through when the scene background is transparent. This is a subjective value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #25881.
Transmission, as implemented in three.js, requires either opaque scene objects, a skybox, or an opaque scene background to serve as a source of light.
Light is transmitted and attenuated from behind the model towards the camera. If there is no light, there is no color.
Consequently, the rendering will be incorrect if the background is transparent. It will also be incorrect even if there is a CSS background, since the CSS background is not accessible to the renderer.
This workaround ensures a background is present during the transmission calculation to serve as a source of light.