Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Rename FatPoints to InstancedPoints #26965

Merged
merged 8 commits into from
Oct 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/files.json
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@
"webgpu_depth_texture",
"webgpu_equirectangular",
"webgpu_instance_mesh",
"webgpu_instance_points",
"webgpu_instance_uniform",
"webgpu_lights_custom",
"webgpu_lights_ies_spotlight",
Expand All @@ -339,7 +340,6 @@
"webgpu_morphtargets",
"webgpu_occlusion",
"webgpu_particles",
"webgpu_points_fat",
"webgpu_rtt",
"webgpu_sandbox",
"webgpu_shadowmap",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ import {

const _vector = new Vector3();

class FatPointsGeometry extends InstancedBufferGeometry {
class InstancedPointsGeometry extends InstancedBufferGeometry {

constructor() {

super();

this.isFatPointsGeometry = true;
this.isInstancedPointsGeometry = true;

this.type = 'FatPointsGeometry';
this.type = 'InstancedPointsGeometry';

const positions = [ - 1, 1, 0, 1, 1, 0, - 1, - 1, 0, 1, - 1, 0 ];
const uvs = [ - 1, 1, 1, 1, - 1, - 1, 1, - 1 ];
Expand Down Expand Up @@ -171,4 +171,4 @@ class FatPointsGeometry extends InstancedBufferGeometry {

}

export { FatPointsGeometry };
export default InstancedPointsGeometry;
21 changes: 21 additions & 0 deletions examples/jsm/nodes/accessors/InstancedPointsMaterialNode.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import MaterialNode from './MaterialNode.js';
import { addNodeClass } from '../core/Node.js';
import { nodeImmutable } from '../shadernode/ShaderNode.js';

class InstancedPointsMaterialNode extends MaterialNode {

setup( /*builder*/ ) {

return this.getFloat( this.scope );

}

}

InstancedPointsMaterialNode.POINT_WIDTH = 'pointWidth';

export default InstancedPointsMaterialNode;

export const materialPointWidth = nodeImmutable( InstancedPointsMaterialNode, InstancedPointsMaterialNode.POINT_WIDTH );

addNodeClass( 'FatPointsMaterialNode', InstancedPointsMaterialNode );
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,15 @@ import { materialColor, materialPointWidth } from '../accessors/MaterialNode.js'
import { modelViewMatrix } from '../accessors/ModelNode.js';
import { positionGeometry } from '../accessors/PositionNode.js';
import { smoothstep } from '../math/MathNode.js';
import { tslFn, vec2, vec4 } from '../shadernode/ShaderNode.js';
import { tslFn, vec2, vec4, color } from '../shadernode/ShaderNode.js';
import { uv } from '../accessors/UVNode.js';
import { viewport } from '../display/ViewportNode.js';
import { color } from 'three/nodes';

import { PointsMaterial } from 'three';

const defaultValues = new PointsMaterial();

class FatPointsNodeMaterial extends NodeMaterial {
class InstancedPointsNodeMaterial extends NodeMaterial {

constructor( params = {} ) {

Expand Down Expand Up @@ -158,6 +157,6 @@ class FatPointsNodeMaterial extends NodeMaterial {

}

export default FatPointsNodeMaterial;
export default InstancedPointsNodeMaterial;

addNodeMaterial( 'FatPointsNodeMaterial', FatPointsNodeMaterial );
addNodeMaterial( 'InstancedPointsNodeMaterial', InstancedPointsNodeMaterial );
2 changes: 1 addition & 1 deletion examples/jsm/nodes/materials/Materials.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// @TODO: We can simplify "export { default as SomeNode, other, exports } from '...'" to just "export * from '...'" if we will use only named exports

export { default as NodeMaterial, addNodeMaterial, createNodeMaterialFromType } from './NodeMaterial.js';
export { default as FatPointsNodeMaterial } from './FatPointsNodeMaterial.js';
export { default as InstancedPointsNodeMaterial } from './InstancedPointsNodeMaterial.js';
export { default as LineBasicNodeMaterial } from './LineBasicNodeMaterial.js';
export { default as LineDashedNodeMaterial } from './LineDashedNodeMaterial.js';
export { default as Line2NodeMaterial } from './Line2NodeMaterial.js';
Expand Down
21 changes: 21 additions & 0 deletions examples/jsm/objects/InstancedPoints.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import {
Mesh
} from 'three';
import InstancedPointsGeometry from '../geometries/InstancedPointsGeometry.js';
import InstancedPointsNodeMaterial from '../nodes/materials/InstancedPointsNodeMaterial.js';

class InstancedPoints extends Mesh {

constructor( geometry = new InstancedPointsGeometry(), material = new InstancedPointsNodeMaterial() ) {

super( geometry, material );

this.isInstancedPoints = true;

this.type = 'InstancedPoints';

}

}

export default InstancedPoints;
21 changes: 0 additions & 21 deletions examples/jsm/points/FatPoints.js

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>three.js webgpu - points - fat</title>
<title>three.js webgpu - points - instanced</title>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, user-scalable=no, minimum-scale=1.0, maximum-scale=1.0">
<link type="text/css" rel="stylesheet" href="main.css">
Expand All @@ -11,7 +11,7 @@

<div id="container"></div>

<div id="info"><a href="https://threejs.org" target="_blank">three.js</a> - fat points</div>
<div id="info"><a href="https://threejs.org" target="_blank">three.js</a> - instanced points</div>

<script type="importmap">
{
Expand All @@ -37,11 +37,11 @@
import { GUI } from 'three/addons/libs/lil-gui.module.min.js';
import { OrbitControls } from 'three/addons/controls/OrbitControls.js';

import { FatPoints } from 'three/addons/points/FatPoints.js';
//import { FatPointsNodeMaterial } from 'three/addons/points/FatPointsNodeMaterial.js'; // why not this, instead?
import { FatPointsGeometry } from 'three/addons/points/FatPointsGeometry.js';
import InstancedPoints from 'three/addons/objects/InstancedPoints.js';
//import InstancedPointsNodeMaterial from 'three/addons/materials/InstancedPointsNodeMaterial.js'; // why not this, instead?
import InstancedPointsGeometry from 'three/addons/geometries/InstancedPointsGeometry.js';

import { color, FatPointsNodeMaterial } from 'three/nodes';
import { color, InstancedPointsNodeMaterial } from 'three/nodes';

import * as GeometryUtils from 'three/addons/utils/GeometryUtils.js';

Expand Down Expand Up @@ -111,15 +111,15 @@

}

// Fat Points
// Instanced Points

const geometry = new FatPointsGeometry();
const geometry = new InstancedPointsGeometry();
geometry.setPositions( positions );
geometry.setColors( colors );

geometry.instanceCount = positions.length / 3; // this should not be necessary

material = new FatPointsNodeMaterial( {
material = new InstancedPointsNodeMaterial( {

color: 0xffffff,
pointWidth: 10, // in pixel units
Expand All @@ -129,9 +129,9 @@

} );

const fatPoints = new FatPoints( geometry, material );
fatPoints.scale.set( 1, 1, 1 );
scene.add( fatPoints );
const instancedPoints = new InstancedPoints( geometry, material );
instancedPoints.scale.set( 1, 1, 1 );
scene.add( instancedPoints );

//

Expand Down