Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons: Don't expose LWO parsers. #26996

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

CodyJasonBennett
Copy link
Contributor

Follow-up to #26910.

Description

I had previously exported examples/jsm/loaders/lwo, but this isn't user-facing code and dependencies of other loaders.

I'm keeping them as an implementation detail as I do examples/jsm/libs.

@mrdoob mrdoob added this to the r158 milestone Oct 18, 2023
@mrdoob mrdoob merged commit f8d9859 into mrdoob:dev Oct 18, 2023
18 checks passed
@CodyJasonBennett CodyJasonBennett deleted the addons-lwo branch October 18, 2023 03:42
@Methuselah96 Methuselah96 mentioned this pull request Oct 22, 2023
16 tasks
@WORMSS
Copy link
Contributor

WORMSS commented Oct 27, 2023

!!!! This makes me sad...
I was using these imports to replace part of the prototype to fix the loaders of LWO.
Since the mesh are loaded with incorrect geometry/origin positions.

@WORMSS
Copy link
Contributor

WORMSS commented Oct 27, 2023

Never mind, I found I can just import from the files location directly and mangle the file from there.

@CodyJasonBennett
Copy link
Contributor Author

This only prevents access from the addons export import { IFFParser } from 'three/addons'. You can import from three/addons/* or three/examples/jsm/* as per usual -- examples/jsm/libs for instance.

@WORMSS
Copy link
Contributor

WORMSS commented Oct 27, 2023

I really need to get my example .lwo files sorted, so we can actually get #26733 fixed in the first place, and then wouldn't need to mangle the files at all.

Need to do the same for #26894
and also #26741 while I am at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants